Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is no api to get messages in latest ts #6610

Closed
hunjixin opened this issue Jun 28, 2021 · 4 comments
Closed

there is no api to get messages in latest ts #6610

hunjixin opened this issue Jun 28, 2021 · 4 comments

Comments

@hunjixin
Copy link
Contributor

Describe the solution you'd like
i want to add a api ***MessageForTipset ***that can return messages in specify tipset key, but not return parent tipset message. i have no way to get messages in latest tipset.

@hunjixin hunjixin changed the title there is not api to get messages in latest ts there is no api to get messages in latest ts Jun 28, 2021
@f8-ptrk
Copy link
Contributor

f8-ptrk commented Jun 28, 2021

@hunjixin
Copy link
Contributor Author

hunjixin commented Jul 1, 2021

@f8-ptrk @jennijuju yes. i can copy the code of blockmsgfortipset to implete a tipset message select in local code. but i must call StateLookupId. this func may be invoked for many times. this code maybe cost a few seconds on network. and hundreds ms in local machine. on the other hand, blockmsgfortipset has relation to network upgrade and different network. this will make my code more complicated. so hope to have such a api to get messages that really to be process in tipset

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Jul 1, 2021

i am sure a parallelized constant lookup api call routine of tipsets-blocks-messages will be faster then a single gettipsetmessages api call if implemented right "client" side in your code

@arajasek
Copy link
Contributor

arajasek commented Jul 3, 2021

Thanks for the PR! Let's track discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants