Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChainGetMessagesInTipset API #6642

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Add ChainGetMessagesInTipset API #6642

merged 6 commits into from
Jul 15, 2021

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jul 1, 2021

No description provided.

@hunjixin
Copy link
Contributor Author

hunjixin commented Jul 1, 2021

#6610

@arajasek
Copy link
Contributor

arajasek commented Jul 3, 2021

Build is unhappy, but I think this is a reasonable thing to add.

@hunjixin hunjixin force-pushed the feat/add_getmessagesints_api branch 2 times, most recently from 11c2b17 to 6404794 Compare July 5, 2021 06:38
magik6k
magik6k reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it would be really great to have a test for this.

https://github.com/filecoin-project/lotus/blob/master/itests/nonce_test.go is one of the tests which does some message sending, so it should be easy to write a new test based off it. (when writing itests, after creating a new file in the itests directory make sure to run make circleci to update the CI config)

@jennijuju jennijuju added the need/author-input Hint: Needs Author Input label Jul 5, 2021
@jennijuju
Copy link
Member

Test awaiting @hunjixin

@hunjixin
Copy link
Contributor Author

hunjixin commented Jul 6, 2021

@jennijuju done

@hunjixin hunjixin force-pushed the feat/add_getmessagesints_api branch from 6f6fec1 to d023026 Compare July 15, 2021 06:55
@hunjixin
Copy link
Contributor Author

@jennijuju update

@magik6k
Copy link
Contributor

magik6k commented Jul 15, 2021

Thanks for the PR!

@magik6k magik6k changed the title Feat/add getmessagesints api Add ChainGetMessagesInTipset API Jul 15, 2021
@magik6k magik6k merged commit f07a370 into filecoin-project:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
need/author-input Hint: Needs Author Input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hunjixin @arajasek @jennijuju @magik6k