Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand StateActorCodeCIDs to support network version <16 #8934

Closed
5 of 15 tasks
jennijuju opened this issue Jun 28, 2022 · 1 comment · Fixed by #8941
Closed
5 of 15 tasks

expand StateActorCodeCIDs to support network version <16 #8934

jennijuju opened this issue Jun 28, 2022 · 1 comment · Fixed by #8941
Labels

Comments

@jennijuju
Copy link
Member

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

atm for network <=v15 that uses go actor, the call will throw a warning

2022-06-23T23:56:48.761Z	WARN	rpc	[email protected]/handler.go:279	error in RPC call to 'Filecoin.StateActorCodeCIDs': cannot get manifest CID:
    github.com/filecoin-project/lotus/node/impl/full.(*StateAPI).StateActorCodeCIDs
        /lotus/node/impl/full/state.go:1475

expand this call for all network versions supported.

@jennijuju
Copy link
Member Author

another option is simply having this api only support nv 16 & up for builtin actors, and have the error wrapped more gracefully. but I think expanding it makes more sense, we may deprecate the support for go actor later in v1 API if desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant