-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: api: Api call to get actor cids works for versions < 16 #8941
Conversation
d43a062
to
10dc957
Compare
Codecov Report
@@ Coverage Diff @@
## release/v1.16.0 #8941 +/- ##
===================================================
- Coverage 41.53% 40.75% -0.78%
===================================================
Files 698 701 +3
Lines 81664 77717 -3947
===================================================
- Hits 33916 31671 -2245
+ Misses 41990 40620 -1370
+ Partials 5758 5426 -332
|
10dc957
to
df1d5d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we're doing this big method, we should definitely get rid of the individual methods called GetMultisigActorCodeID
(etc.).
378d204
to
1da3ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits, but LGTM!
1da3ca1
to
3613e28
Compare
3613e28
to
3079920
Compare
cf62ac5
to
484caff
Compare
484caff
to
4bebce0
Compare
- replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut
- replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut
* deps: update to lotus v0.16.0 * refactor: remove unused actor gen code * chore: update actor code generator for v8 * gen: init actor accessors * gen: market actor accessors * gen: multisig actor accessors * gen: power actor accessors * gen: reward actor accessors * gen verifreg actor accessors * gen: miner actor accessors * chore: update miner state extractors - required due to changes in miner actor gen accessors * chore: update market actor extractors - required for market actor gen accessors * gen: builtin accessors * refactor: remove unused map opts lookup - actor accessors now return map opt values * chore: update message test deps - use v8 actor structs * feat: add actor CID lookups - replace with filecoin-project/lotus#8941 when lotus v1.17.0 is cut * chore: update lens interface to match lotus api - required due to lotus update v1.16.0 * refactor: register new actor code in processor * fix: update parsed message extractor with new exitcode * fix: only init VM for network version prior to 13 - ensures we can process message on FVM upgrade boundary * Add is_string column to market_deal_proposal model (#1015) * chore: add is_string column to market_deal_proposal model * fix: many incorrect pointer equality comparisons (#1018) * fix: many incorrect pointer equality comparisons
Related Issues
Closes #8934
Proposed Changes
StateActorCodeCIDs
now works for all network/actors versions.Added a new API call
StateActorManifestCID
to get the manifest cid separately to makeStateActorCodeCIDs
cleaner and more uniform across versionsAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps