Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor: return randomness base to FVM without hashing #11167

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Aug 14, 2023

Related Issues

filecoin-project/ref-fvm#1277

Proposed Changes

  • split DrawRandomness into DrawRandomnessFromBase and DrawRandomnessFromDigest
  • do not actually "draw" any randomness when asked by the FVM -- instead, just return the digest

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 14, 2023 19:43
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct.

@Stebalien
Copy link
Member

(needs other PRs before we can actually test/merge, obviously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants