Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unseal bug, reproduce in test #2877

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Fix unseal bug, reproduce in test #2877

merged 2 commits into from
Aug 6, 2020

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Aug 6, 2020 •
edited
Loading

Goals

For the moment, just replicate #2872 in test.

Implementation

  • Build an api for Getting Updates on a deal in the miner
  • Build a test that tries retrieval at the immediate moment it becomes possible: when the test is written to the deal store
  • Fix the issue by just adding a nil check -- if commD == nil, pass cid.Undef to ReadPiece. It is only used if there is no unsealed copy of the sector

@hannahhoward hannahhoward changed the base branch from master to next August 6, 2020 20:18
@hannahhoward
fix(markets): fix unsealing bug
78aa615 
when commD hasn't been set, just pass cid.Undef
@hannahhoward hannahhoward changed the title WIP: Fix unseal bug, reproduce in test Fix unseal bug, reproduce in test Aug 6, 2020
@magik6k magik6k merged commit 4a831f3 into next Aug 6, 2020
@magik6k magik6k deleted the fix/unsealbug branch August 6, 2020 20:51
@hannahhoward hannahhoward mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @magik6k