Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Pool Rudimentary Spam Protection Measures #3313

Merged
merged 22 commits into from
Aug 28, 2020
Merged

Message Pool Rudimentary Spam Protection Measures #3313

merged 22 commits into from
Aug 28, 2020

Commits on Aug 26, 2020

  1. remove duplicate check 

    gas limit is checked against block gas limit in ValidForBlockInclusion
    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    da9630c View commit details
    Browse the repository at this point in the history

  2. check message before adding in PushWithNonce

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    835dbfe View commit details
    Browse the repository at this point in the history

  3. refactor balance check, apply it in PushWithNonce

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    77f6e0d View commit details
    Browse the repository at this point in the history

  4. track required funds in message set

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    4ac9828 View commit details
    Browse the repository at this point in the history

  5. check aggregate pending message required funds against balance

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    4adb83e View commit details
    Browse the repository at this point in the history

  6. fix tests

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    b59f584 View commit details
    Browse the repository at this point in the history

  7. ErrBroadcastAnyway is now ErrValidationFailure

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    7887694 View commit details
    Browse the repository at this point in the history

  8. include message Value only in soft validation failures

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    87e6c09 View commit details
    Browse the repository at this point in the history

  9. give some score weight to the messages topic

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    bedbdca View commit details
    Browse the repository at this point in the history

  10. rename ErrValidationFailure to ErrSoftValidationFailure 

    to make it clear to readers that this failure is soft; we might be out of sync.
    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c473d3c View commit details
    Browse the repository at this point in the history

  11. correctly account for message replacement in required funds tracking

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a2c0c10 View commit details
    Browse the repository at this point in the history

  12. better code for getRequiredFunds

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    7a70668 View commit details
    Browse the repository at this point in the history

  13. always verify message min gas

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    4919a00 View commit details
    Browse the repository at this point in the history

  14. move msg serialization outside of lock, consistently use curTs

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    8848c54 View commit details
    Browse the repository at this point in the history

  15. comment out Value inclusion for required funds tracking 

    we are not sure whether we want it yet.
    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    793eda9 View commit details
    Browse the repository at this point in the history

  16. check gas fee cap for minimum value

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    8db262c View commit details
    Browse the repository at this point in the history

  17. cast min base fee to uint64

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d3e95d6 View commit details
    Browse the repository at this point in the history

  18. rate limit messages per actor by enforcing maximum pending message limit

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ad889a7 View commit details
    Browse the repository at this point in the history

  19. fix tests

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    6abfbbd View commit details
    Browse the repository at this point in the history

  20. named error for too many pending messages

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    82ef052 View commit details
    Browse the repository at this point in the history

  21. log error if we trip over too many pending messages for actor

    @vyzo
    vyzo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    038e83b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. flag to allow add to skip limit check 

    essential for correctness in the revert case
    @vyzo
    vyzo committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    708a8b6 View commit details
    Browse the repository at this point in the history