Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable codecov annotations #3514

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 3, 2020

This seems to be a new, enabled by default feature of codecov, where it annotates all uncovered lines by default, which in the world of Go makes file views unusable

Exhibit A - https://github.com/filecoin-project/lotus/pull/3497/files#diff-8a8fba801c71449b9064ff7c4592a012

This PR should disable those

@magik6k magik6k requested a review from Kubuxu September 3, 2020 11:42
@Kubuxu Kubuxu merged commit 13c828f into master Sep 3, 2020
@Kubuxu Kubuxu deleted the ci/disable-codecov-annotations branch September 3, 2020 11:47
@vyzo
Copy link
Contributor

vyzo commented Sep 3, 2020

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants