paych: get available funds by address or by from/to #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
commented
Sep 4, 2020
| @@ -207,22 +207,23 @@ type FullNodeStruct struct { | |||
|
|
|||
| MarketEnsureAvailable func(context.Context, address.Address, address.Address, types.BigInt) (cid.Cid, error) `perm:"sign"` | |||
|
|
|||
| PaychGet func(ctx context.Context, from, to address.Address, amt types.BigInt) (*api.ChannelInfo, error) `perm:"sign"` | |||
There was a problem hiding this comment.
Just an indentation change
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if avail.Channel == nil { |
There was a problem hiding this comment.
The logic of formatting the channel status output is the same, it's just been extracted into a method that's called by both paych status and paych status-by-from-to
| } | ||
| } | ||
|
|
||
| func (ca *channelAccessor) currentAvailableFunds(queuedAmt types.BigInt) (*api.ChannelAvailableFunds, error) { |
There was a problem hiding this comment.
Moved the logic for what to do if the channel is not found into the manager layer
magik6k
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a method to get available funds for a channel by from/to, which makes sense from CLI. However for markets non-blocking retrieval it makes more sense to get funds by channel address.
This PR adds a new API method to get available funds by channel address. So now there are two API methods to get available funds for a channel: