fix: restrict actor exit codes to non-system codes #3653
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts actor methods from exiting with a system exit code. If an actor aborts with a system exit code, it is caught and changed to an
SysErrorIllegalActor
.This conveniently also guards against actors using negative exit codes.
In #3199 @anorth suggested changing
Runtime.Abortf
to do this check, but this function is used by the runtime itself to abort with system exit codes and would not guard against an actor callingpanic(aerrors.New(exitcode.SysErrInsufficientFunds, "actor made a system error"))
directly.refs filecoin-project/test-vectors#15