Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to hide sectors in Removed from sectors list. #3903

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Add an option to hide sectors in Removed from sectors list. #3903

merged 2 commits into from
Sep 21, 2020

Conversation

jennijuju
Copy link
Member

fix #3605

@jennijuju jennijuju changed the title Add an option to hide sectors in Removed for sectors list. Add an option to hide sectors in Removed from sectors list. Sep 17, 2020
travisperson
travisperson approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@travisperson travisperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run gofmt on this file?

@jennijuju
Copy link
Member Author

Can you run gofmt on this file?

Can you run gofmt on this file?

updated

magik6k
magik6k approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (pushed a commit to invert the flag to hide those by default, I think that's better UX)

@magik6k magik6k merged commit 29913f4 into master Sep 21, 2020
@magik6k magik6k deleted the 3605-sector-list-option branch September 21, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@travisperson travisperson travisperson approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally hide removed sectors from lotus-miner sectors list
3 participants
@jennijuju @travisperson @magik6k