Added an option to show or not show sector info for lotus-miner info
#4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
jennijuju
force-pushed
the
option-to-hide-sectors
branch
2 times, most recently
from
fb78013
to
3d7adba
Compare
magik6k
reviewed
Sep 28, 2020
cmd/lotus-storage-miner/info.go
Outdated
Comment on lines
38
to
39
| Name: "show-sectors-info", | ||
| Usage: "show sectors info", |
There was a problem hiding this comment.
I'd make this flag inverted, so the default is to show the sectors (hide-sectors)
jennijuju
force-pushed
the
option-to-hide-sectors
branch
2 times, most recently
from
3a81b3e
to
78f5492
Compare
jennijuju
force-pushed
the
option-to-hide-sectors
branch
from
78f5492
to
64f24fd
Compare
magik6k
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3913 (more on surface level)
Should consider implementing #4002 to fix it from root.