-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make message signer nonce generation transactional #4165
Conversation
ee8998e
to
1406715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when is the nonce incremented?
(testing manually) |
(seems to work, with the right stuff in the datastore) |
I don't think this will resolve the issue: |
they will have to manually clear the mpool with |
Fixes two problems with nonce generation:
Mpool.Push
failed, there would be a gap between nonces