Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an api for removing multisig signers #4274

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Conversation

whyrusleeping
Copy link
Member

No description provided.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remove changes make sense, but I'm missing context on the changes to MsigApprove.

@whyrusleeping
Copy link
Member Author

@Stebalien its fixing some really terrible UX.

@Stebalien
Copy link
Member

But it's a very late breaking change to a widely used (I assume?) API. I agree with the change in general, I just want to make sure you've thought about the fallout). We can always add an ApproveWithoutTxnHash function.

@whyrusleeping
Copy link
Member Author

@Stebalien yep. Breaking the API on purpose. will be much harder the longer we wait.

@Stebalien
Copy link
Member

Fair enough.

@magik6k magik6k merged commit 651522c into master Oct 10, 2020
@magik6k magik6k deleted the feat/msig-remove-api branch October 10, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants