Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return true when deadlines changed #4403

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Oct 14, 2020

The method name DeadlinesChanged suggests it will return true when the deadlines have changed when in fact it returns false. This PR addresses this by having the methods return true when the deadlines have changed. The method DeadlinesChnaged is called in chainwatch and in DiffDeadlines. Neither of these methods are called in lotus.

A similar issue exists for PartitionsChanged as well that has been addressed here.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@frrist
Copy link
Member Author

frrist commented Oct 14, 2020

test failures appear to be unrelated/flaky.

@magik6k magik6k merged commit d02d4bc into master Oct 14, 2020
@magik6k magik6k deleted the frrist/fix-miner-shim-impls branch October 14, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants