Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filters for retrieval deals #4424

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Oct 15, 2020

Problem

We would like to have custom user filters for retrieval deals, like we have for storage deals.

Solution

If a custom filter is set in Dealmaking.Filter, use it when deciding on both retrieval deals and storage deals. The JSON passed to the custom filter will be augmented with "DealType": <"storage" | "retrieval"> so that the custom filter can distinguish between the two types of deals.

Resolves #4195

@ingar ingar marked this pull request as ready for review October 15, 2020 17:12
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me!

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just 1 comment

node/builder.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 111942b into master Oct 16, 2020
@magik6k magik6k deleted the feat/retrieval-cli-deal-filter branch October 16, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a retrieval-deal filter similar ( if not identical ) to the storage-filter
3 participants