-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve StateMsg APIs #4429
Improve StateMsg APIs #4429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGWM but it changes the API, removal of StateMsgGasCost and change to StateReplay
7e8d14f
to
b8308e9
Compare
lotuspond/front/src/Block.js
Outdated
@@ -26,7 +26,7 @@ class Block extends React.Component { | |||
|
|||
messages = await Promise.all(messages.map(async (msg, i) => { | |||
if (msg.receipt.ExitCode !== 0) { | |||
let reply = await this.props.conn.call('Filecoin.StateReplay', [{Cids: [this.props.cid], Blocks: [header], Height: header.Height}, msg.Cid]) | |||
let reply = await this.props.conn.call('Filecoin.StateTransplant', [{Cids: [this.props.cid], Blocks: [header], Height: header.Height}, msg.Cid]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than your horrible oversight in the most important part of the PR, this LGTM
b8308e9
to
2fd4a97
Compare
How about add tipset height for the state message? I need to know the message in which tipset and the message all cost, use the formula ((Gas Premium + Base Fee) * Gas Limit), or the RPC return the message all cost. |
InvocResult
StateReplay
toStateTransplant
, as suggested by @raulkStateMsgGasCost
into the newStateReplay
, which searches for the specified msg and replays it if found exactly as it was applied on chain