Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: add ClaimsChanged and DiffClaims method to power shim #4628

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Oct 28, 2020

Motivated by inspection performed in Visor.

@frrist frrist marked this pull request as draft October 28, 2020 21:34
@frrist frrist marked this pull request as ready for review October 29, 2020 00:04
}

func fromV2Claim(v2 power2.Claim) Claim {
return Claim{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

power2.Claim has an extra field (SealProofType) that Claim does not, I think ignoring it here should be fine but wanted to flag.

Claim Claim
}

func DiffClaims(pre, cur State) (*ClaimChanges, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien would you mind giving this a second look, I've added this since the initial request for review.

@frrist
Copy link
Member Author

frrist commented Oct 29, 2020

TestSyncFork is failing, but unrelated to changes here -- new code isn't called in lotus.

@frrist frrist changed the title polish: add ClaimsChanged method to power shim polish: add ClaimsChanged and DiffClaims method to power shim Oct 29, 2020
@magik6k magik6k merged commit 862c5b6 into master Oct 30, 2020
@magik6k magik6k deleted the frrist/power-claims-changed branch October 30, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants