-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate new optional blst backend and verification optimizations from proofs #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building with the
|
Closed
dignifiedquire
force-pushed
the
feat/new-blst
branch
from
November 2, 2020 16:06
b4f99f9
to
18baa91
Compare
dignifiedquire
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
November 2, 2020 16:06
I am unclear what the CI failures are about. But I do know that oni will need to remove fil-blst and update filecoin-ffi. |
magik6k
force-pushed
the
feat/new-blst
branch
from
November 3, 2020 10:03
18baa91
to
5c30552
Compare
magik6k
approved these changes
Nov 3, 2020
magik6k
changed the title
[WIP] feat: integrate new optional blst backend and verification optimizations from proofs
feat: integrate new optional blst backend and verification optimizations from proofs
Nov 3, 2020
karalabe
reviewed
Nov 3, 2020
[submodule "extern/oni"] | ||
path = extern/oni | ||
url = https://github.com/filecoin-project/oni | ||
[submodule "extern/blst"] | ||
path = extern/blst | ||
url = [email protected]:supranational/blst.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the build on machines that don't have github pubkeys setup. You need https here, not git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blst
to thev0.2.0
release, to ensure it matches the version used byblstrs
(the recursive dependency integratingblst
intofilecoin-ffi
filecoin-ffi
with the latest optimizations for verification and the blst backendYou can enable the
blst
backend when building from source usingFFI_USE_BLST=1
Depends on
Fixes #4678