Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init actor address map diffing #4875

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix init actor address map diffing #4875

merged 1 commit into from
Nov 16, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 16, 2020

What

Replace init actor address map diffing with generic adt diffing logics
Optimize other diffing methods by calling Diff* iff adt CID's are different.

Comment on lines -572 to -575
_, found, err := newState.ResolveAddress(newAddress)
if err != nil {
return err
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation for change lies in the bug here. This should be looking in the oldState to see if a new address has been added. New ADT logic avoids this bug.

@magik6k magik6k merged commit a152d98 into master Nov 16, 2020
@magik6k magik6k deleted the frrist/fix-init-pred branch November 16, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants