Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes to worker return #4890

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 17, 2020

We're bumping API versions in 1.2.0 already, so getting this in now is nice because we can avoid breaking worker APIs again

This is part 1 of 2 of handling things like failing to allocate storage more gracefully. Part 2 will be handling those errors at the scheduler level, just returning tasks which got Temp errors to the scheduler instead of failing them

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magik6k magik6k merged commit 6520266 into release/v1.2.0 Nov 17, 2020
@magik6k magik6k deleted the feat/worker-error-codes branch November 17, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants