Disable gas burning for window post messages #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
arajasek
force-pushed
the
release/v1.3.0
branch
from
b32e464
to
1c61d08
Compare
Stebalien
approved these changes
Dec 16, 2020
arajasek
force-pushed
the
release/v1.3.0
branch
from
1c61d08
to
5750c08
Compare
Stebalien
force-pushed
the
release/v1.3.0
branch
2 times, most recently
from
5b3336b
to
7e3b3c8
Compare
|
Link to the FIP? |
|
@anorth Good call! Edited the description. |
anorth
approved these changes
Dec 16, 2020
| @@ -41,6 +41,8 @@ const UpgradeKumquatHeight = 170000 | |||
| const UpgradeCalicoHeight = 265200 | |||
| const UpgradePersianHeight = UpgradeCalicoHeight + (builtin2.EpochsInHour * 60) | |||
|
|
|||
| const UpgradeClausHeight = 343200 | |||
There was a problem hiding this comment.
Nit: it would be helpful to readers to include datestamps alongside these.
chain/vm/burn.go
Outdated
| @@ -76,7 +76,12 @@ func ComputeGasOutputs(gasUsed, gasLimit int64, baseFee, feeCap, gasPremium abi. | |||
| baseFeeToPay = feeCap | |||
| out.MinerPenalty = big.Mul(big.Sub(baseFee, feeCap), gasUsedBig) | |||
| } | |||
| out.BaseFeeBurn = big.Mul(baseFeeToPay, gasUsedBig) | |||
|
|
|||
| // If burning is disabled, just skip computing the BaseFeeBurn. However, | |||
There was a problem hiding this comment.
"network transaction fee" would be more descriptive than burn, here and for the parameter name.
While over-estimation fees and miner tips are still paid, gas is no longer burnt for direct, successful window PoSt messages. Usually, gas is burnt to prevent an attacker from spamming the network and to allow clients to "price" messages (using the base fee cap) based on how urgently they need them to be processed. However: 1. Window PoSt is already a "proof of work". 2. Miners need to submit WindowedPoSts on-time so all window post messages are urgent. 3. Work is already under way to move window post verification off-chain (making it effectively free). This change simply introduces the "free" part a bit earlier.
arajasek
force-pushed
the
release/v1.3.0
branch
from
7e3b3c8
to
1f754bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0009.md
While over-estimation fees and miner tips are still paid, gas is no longer burnt
for direct, successful window PoSt messages.
Usually, gas is burnt to prevent an attacker from spamming the network and to
allow clients to "price" messages (using the base fee cap) based on how urgently
they need them to be processed. However:
it effectively free). This change simply introduces the "free" part a bit earlier.
Upgrade epoch set for Monday, Dec 21st, 18:00 PST.