Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we can't dispute a correct window post #5406

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

Stebalien
Copy link
Member

Add a test to make sure disputing a valid window post fails.

@@ -211,3 +211,16 @@ func TestWindowPostDispute(t *testing.T) {

test.TestWindowPostDispute(t, builder.MockSbBuilder, 2*time.Millisecond)
}

func TestWindowPostDisputeFails(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes... And the reason the TestWindowPostDispute and TestWIndowedPost don't run at the same time... is the ed.

@magik6k magik6k merged commit 9827ec3 into next Jan 25, 2021
@magik6k magik6k deleted the feat/test-window-post-dispute-fail branch January 25, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants