Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor coalescing logic into its own function, take both cancellation sets into account #5507

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 2, 2021

No description provided.

@vyzo vyzo marked this pull request as ready for review February 2, 2021 19:57
@vyzo
Copy link
Contributor Author

vyzo commented Feb 2, 2021

So this is a small refactoring and an additional sanity check -- we thought there was a bug, but it was a case of Garbage In, Garbage Out.
I think we should still merge it.

@magik6k magik6k merged commit fcbd995 into master Feb 10, 2021
@magik6k magik6k deleted the fix/coalescer branch February 10, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants