Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build-lotus-soup ci job #5554

Merged
merged 3 commits into from
Feb 8, 2021
Merged

fix build-lotus-soup ci job #5554

merged 3 commits into from
Feb 8, 2021

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Feb 8, 2021

Currently build-lotus-soup job is failing on CI, due to missing step to fetch latest lotus dependency from master.

@@ -165,7 +165,7 @@ func PrepareMiner(t *TestEnvironment) (*LotusMiner, error) {
return nil, err
}

ds, err := lr.Datastore(context.Background(), "/metadata")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, sorry about this.

The problem was that build-lotus-soup was missing a step to go get github.com/filecoin-project/lotus@master and this was indeed building an outdated commit from master.

I've added the step, so now on every CI run, we build against Lotus from master, which is what we want.

@nonsense nonsense changed the title fix testplans build fix build-lotus-soup ci job Feb 8, 2021
@magik6k magik6k merged commit 3f112d0 into master Feb 8, 2021
@magik6k magik6k deleted the fix-testplans-build branch February 8, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants