Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrapper profile setting #5756

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix bootstrapper profile setting #5756

merged 1 commit into from
Mar 10, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 9, 2021

node.Online()->LibP2P would override it again, setting it to false - https://github.com/filecoin-project/lotus/blob/master/node/builder.go#L194

@magik6k magik6k requested a review from vyzo March 9, 2021 22:47
vyzo
vyzo approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch!

@coryschwartz coryschwartz mentioned this pull request Mar 10, 2021
Closed
@magik6k magik6k merged commit 268abb5 into next Mar 10, 2021
@magik6k magik6k deleted the fix/bootstrapper-profile branch March 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @vyzo