Testground checks on push #5887
Conversation
coryschwartz
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
We need to figure out which of these test plans we'll actually want (concerns around stability / we already fail some of these). Need to poke @nonsense probably. |
| - backend_addr: ci.testground.ipfs.team | ||
| backend_proto: https | ||
| plan_directory: testplans/graphsync | ||
| composition_file: testplans/graphsync/_compositions/stress-k8s.toml |
There was a problem hiding this comment.
This one probably doesn't belong to Lotus. I think if we have the graphsync repo first the graphsync tests, it'd be better!
There was a problem hiding this comment.
Thanks, I'll remove this one.
I believe we want both testplans related to Lotus - the end-to-end deals one, as well as the payment channels stress-test. The graphsync test plan should live in the graphsync repo I believe. There is no reason for any of these to be flaky or to not work ever, so I think it is great that we are adding the status checks! Thanks @coryschwartz !!! |
|
@magik6k is going to open a GitHub issue to track the work for fixing the failing/flaky tests and then relate to this PR, since that is what's blocking this. |
|
I think this is a great start. Ideally Testground itself could handle this (this functionality is buggy and not working on Testground unfortunately), and not have an additional Github Action handle the status checks updates, but I think for now this is fine. Given that we will probably have more test plans in the future, It'd be nice to collect all Testground testplans related to Lotus under one status check, and not as individual status checks, however we only have 2 tests right now, so this is fine as is for a start. Once |
I think both the |
magik6k
force-pushed
the
feat/gh-action-testground-prs
branch
from
aab5fa0
to
05dbe5c
Compare
No description provided.