Fix nonce getting on Lotus lite #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mpool should probably switch to using that for nonce getting but it also uses Actor data for balance information. |
Kubuxu
force-pushed
the
fix/nonce-getting
branch
from
2dc55b4
to
88d2ace
Compare
Resolves #5593 #5995 Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
fix/nonce-getting
branch
from
88d2ace
to
77d004e
Compare
magik6k
reviewed
Apr 15, 2021
chain/messagesigner/messagesigner.go
Outdated
| @@ -97,7 +97,7 @@ func (ms *MessageSigner) nextNonce(addr address.Address) (uint64, error) { | |||
| // that have mempool nonces, so first check the mempool for a nonce for | |||
| // this address. Note that the mempool returns the actor state's nonce | |||
| // by default. | |||
| nonce, err := ms.mpool.GetNonce(addr) | |||
| nonce, err := ms.mpool.GetNonce(context.TODO(), addr, types.EmptyTSK) | |||
There was a problem hiding this comment.
We have a context in SignMessage, can just use it here
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
fix/nonce-getting
branch
from
1b56bf6
to
66c4089
Compare
magik6k
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5593
Resolves #5995