Introduce v5 actors #6195
Introduce v5 actors #6195
Conversation
arajasek
force-pushed
the
asr/v5-skeleton
branch
2 times, most recently
from
e8b6aba
to
a36f1e9
Compare
arajasek
force-pushed
the
asr/v5-skeleton
branch
3 times, most recently
from
9bd2d47
to
a6e1845
Compare
| @@ -39,6 +39,8 @@ var UpgradeNorwegianHeight = abi.ChainEpoch(40) | |||
|
|
|||
| var UpgradeActorsV4Height = abi.ChainEpoch(45) | |||
|
|
|||
| var UpgradeHyperdriveHeight = abi.ChainEpoch(50) | |||
There was a problem hiding this comment.
ActorsV5? I mean, I know hyperdrive is nicer... but it's kind of inconsistent.
That or we can go back and name all the other heights. I'd actually prefer to do it that way.
There was a problem hiding this comment.
Yeah, I'll rename the old ones -- the inconsistency was bothering me too. I think we want to go with Hyperdrive for now (and names from this point on).
There was a problem hiding this comment.
UpgradeHyperspaceBypassHeight? We can totally print some bad poetry at the time of the upgrade.
There was a problem hiding this comment.
Yikes is this upgrade supposed to destroy the earth?!? Idea: AlcubierreOverdrive. Maybe we save that one for the upgrade instantiating aggregator nodes.
|
Test failures will be resolved by filecoin-project/specs-actors#1401 |
| @@ -1053,7 +1057,7 @@ func upgradeActorsV3Common( | |||
| // Perform the migration | |||
| newHamtRoot, err := nv10.MigrateStateTree(ctx, store, stateRoot.Actors, epoch, config, migrationLogger{}, cache) | |||
| if err != nil { | |||
| return cid.Undef, xerrors.Errorf("upgrading to actors v2: %w", err) | |||
| return cid.Undef, xerrors.Errorf("upgrading to actors v3: %w", err) | |||
arajasek
force-pushed
the
asr/v5-skeleton
branch
4 times, most recently
from
399be24
to
7d97722
Compare
|
I think the failures are flaky at this point. I'm going to merge it into the staging branch for now, but we will need to gain confidence in this. |
Actor wrappers generated by codegen
make actors-gen.