Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker-compose file #6544

Merged
merged 9 commits into from
Jul 22, 2021
Merged

add docker-compose file #6544

merged 9 commits into from
Jul 22, 2021

Conversation

coryschwartz
Copy link

@coryschwartz coryschwartz commented Jun 21, 2021

  • fileocin/lotus
    • includes an initialization that pulls form the latest snapshot, similarly to the snap package and DO droplet
    • Runs the lotus daemon by default, which is the most common scenario, and most likely the expected behavior
  • filecoin/lotus-all-in-one
    • includes all the lotus utilities you might want
  • docker-compose
    • help devs get up and running quckly for local development, just run docker-compose up -d and away you go.
    • Has a hint about how to run a miner, but not uncommented by default since many people wouldn't want that.
    • Developers can attach to the fullnode or to the gateway to test against the limited gateway API, test locally before using public gateways.

Dockerfile.lotus Outdated Show resolved Hide resolved
FROM base AS lotus
MAINTAINER Lotus Development Team

COPY --from=builder /opt/filecoin/lotus /usr/local/bin/
COPY --from=builder /opt/filecoin/lotus-shed /usr/local/bin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep lotus-shed, it's really useful


if [ ! -z DOCKER_LOTUS_WALLET_IMPORT ]; then
mkdir $LOTUS_PATH/keystore
cp "${DOCKER_LOTUS_WALLET_IMPORT}" "${LOTUS_PATH}/keystore"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use lotus-shed keyinfo import, it's compatible with lotus export, and lotus-shed keyinfo new [bls|secp256k1|libp2p-host]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good point.

RUN mkdir /var/lib/lotus /var/tmp/filecoin-proof-parameters && chown fc /var/lib/lotus /var/tmp/filecoin-proof-parameters
ENTRYPOINT ["/docker-lotus-entrypoint.sh"]

CMD ["-help"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/docker-lotus-entrypoint.sh doesn't have a help flag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/docker-lotus-entrypoint.sh doesn't have a help flag

It only does because it exec's to lotus at the end.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice

@coryschwartz coryschwartz marked this pull request as ready for review July 20, 2021 22:38
@coryschwartz coryschwartz requested a review from a team as a code owner July 20, 2021 22:38
@BigLep
Copy link
Member

BigLep commented Jul 20, 2021

@coryschwartz : per updated Lotus CR policy, can you get an approval on your team, and then merge if maintainers haven't replied within 2 business days? Ping me on Slack if you need more info here.

@coryschwartz
Copy link
Author

Thanks @BigLep

@travisperson let me know if you see any problems here, I had this sitting in draft for a while so it's already pretty ancient.

@coryschwartz coryschwartz merged commit c08e547 into master Jul 22, 2021
@coryschwartz coryschwartz deleted the feat/docker-compose branch July 22, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants