commit batch: AggregateAboveBaseFee config #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Jul 1, 2021
jennijuju
approved these changes
Jul 1, 2021
jennijuju
reviewed
Jul 1, 2021
| @@ -144,6 +144,10 @@ type SealingConfig struct { | |||
| // time buffer for forceful batch submission before sectors/deals in batch would start expiring | |||
| CommitBatchSlack Duration | |||
|
|
|||
| // network BaseFee below which to stop doing commit aggregation, instead | |||
| // submitting proofs to the chain individually | |||
| AggregateAboveBaseFee types.FIL | |||
There was a problem hiding this comment.
add the default unit please? attofil?nanofil?.. including a table in the pr description on how to set the value in each unit?
There was a problem hiding this comment.
It's basefee in FIL (this is what's types.FIL is)
|
lets update https://docs.filecoin.io/mine/lotus/miner-configuration/#sealing-section please? |
arajasek
approved these changes
Jul 1, 2021
| flush(getSectors(2), true, false), | ||
| }, | ||
| }, | ||
| "addAte-aboveBalancer": { |
| }, | ||
| }, | ||
| "addAte": { | ||
| "addAte-belowBalancer": { |
|
I updated to latest Master - is there a setting in config.toml to adjust the network basefee parameter from 0.15 nFIL? |
|
Yes, this adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6645
This PR adds
AggregateAboveBaseFeeto the Sealing config. The value is used to decide whether or not to do aggregation based on the current network basefee. Defaults to 0.15nFIL based on estimates from https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0013.md#batch-incentive-alignment(also adds a regression test to #6647)