sealing: Handle preCommitParams errors more correctly #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
johnli-helloworld-fix/fsm-error
branch
from
6a17098
to
baf053e
Compare
Stebalien
approved these changes
Jul 21, 2021
Stebalien
force-pushed
the
johnli-helloworld-fix/fsm-error
branch
from
baf053e
to
8029a9f
Compare
Kubuxu
approved these changes
Jul 21, 2021
|
Auto merge won't mere it as the diff is not tested at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing review on #6581