add SealProof in SectorBuilder #6815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
commented
Jul 21, 2021
| @@ -134,7 +134,7 @@ func (m *Miner) SectorsStatus(ctx context.Context, sid abi.SectorNumber, showOnC | |||
| LastErr: info.LastErr, | |||
| Log: log, | |||
| // on chain info | |||
| SealProof: 0, | |||
There was a problem hiding this comment.
We really need SealProof to be set based on the proof type of the sector from the local store, for when we need information on a sector that is not yet on chain. (i.e. lotus-miner is doing a PreCommit1 on a sector, and markets receives a retrieval request for a deal in that sector -- the SealProof is stored in the local store, and we need it to know the expected size of the sector).
magik6k
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing a bug introduced in #6356
As part of MRA, we modified
UnsealSectorto useSectorBuilder.SectorsStatusAPI (RPC frommarketsnode tosealing/provingnode), instead of a local callrpn.miner.GetSectorInfo(sectorID)Given that we always call
sectorsStatuswithonChainInfo == true, we currently get an error for all sectors that are not yet on-chain (i.e. currently in PreCommit1 phase for example).This results in a regression - a failure of all retrievals for deals on sectors that are not yet on chain.
With this PR, I am modifying the call to
sectorsStatusto not use on-chain data, but also making sure thatSealProofis initialised correctly based on data from the local store, and not just to 0.