Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #5109 + suggested fix #6927

Merged
merged 3 commits into from
Jul 29, 2021
Merged

PR #5109 + suggested fix #6927

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c823e9
PR #5109 + suggested fix
ZenGround0 Jul 29, 2021
8ccee51
docsgen
ZenGround0 Jul 29, 2021
11394aa
Improve cli docs
ZenGround0 Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cli/mpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ var MpoolReplaceCmd = &cli.Command{
Usage: "automatically reprice the specified message",
},
&cli.StringFlag{
Name: "max-fee",
Name: "fee-limit",
Usage: "Spend up to X attoFIL for this message (applicable for auto mode)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe document the units and warn that they have changed?

},
},
Expand Down Expand Up @@ -457,13 +457,13 @@ var MpoolReplaceCmd = &cli.Command{
minRBF := messagepool.ComputeMinRBF(msg.GasPremium)

var mss *lapi.MessageSendSpec
if cctx.IsSet("max-fee") {
maxFee, err := types.BigFromString(cctx.String("max-fee"))
if cctx.IsSet("fee-limit") {
maxFee, err := types.ParseFIL(cctx.String("fee-limit"))
if err != nil {
return fmt.Errorf("parsing max-spend: %w", err)
}
mss = &lapi.MessageSendSpec{
MaxFee: maxFee,
MaxFee: abi.TokenAmount(maxFee),
}
}

Expand Down