Remove forgotten non-functioning config from the pre-mainnet days #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribasushi
force-pushed
the
chore/remove-old-tracer
branch
2 times, most recently
from
01ded40
to
ba5e6ed
Compare
ribasushi
force-pushed
the
chore/remove-old-tracer
branch
from
ba5e6ed
to
eefdcb0
Compare
ZenGround0
approved these changes
Aug 2, 2021
| @@ -13,7 +13,7 @@ ListenAddresses = ["/ip4/0.0.0.0/tcp/5678", "/ip6/::/tcp/5678"] | |||
| # | |||
| [Pubsub] | |||
| # Bootstrapper = false | |||
| # RemoteTracer = "/dns4/pubsub-tracer.filecoin.io/tcp/4001/p2p/QmTd6UvR47vUidRNZ1ZKXHrAFhqTJAD27rKL9XYghEKgKX" | |||
| # RemoteTracer = "" | |||
There was a problem hiding this comment.
What's the reason for keeping this dead config field around? What happens if we just remove it instead of zeroing it out?
There was a problem hiding this comment.
@ZenGround0 I do not know enough about this... @whyrusleeping thoughts?
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.