Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize sectors renew #7101

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zlhwdsz
Copy link
Contributor

@zlhwdsz zlhwdsz commented Aug 17, 2021

Optimize subcommands check-expire and renew of lotus-miner sectors:

  • Print timestamp instead of relative time in check-expire results with a customized epochTime function.

  • Move util code to the end of the file.

  • Decompose renew cmd for better readability.

  • Reduce function calls in loops.

@zlhwdsz zlhwdsz changed the title Optimize renew Optimize sectors renew Aug 17, 2021
@zlhwdsz zlhwdsz marked this pull request as ready for review August 17, 2021 09:07
@zlhwdsz zlhwdsz requested a review from a team as a code owner August 17, 2021 09:07
@zlhwdsz
Copy link
Contributor Author

zlhwdsz commented Aug 18, 2021

@ZenGround0 This PR would help a lot in terms of better readability and futrue maintenance.
diff may look like a mess so it's better to review the resulted file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants