Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version for xtools #8494

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Bump version for xtools #8494

merged 1 commit into from
Apr 15, 2022

Conversation

geoff-vball
Copy link
Contributor

Proposed Changes

make gen breaks when using go1.18. Bumping x/tools version fixes this problem.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner April 14, 2022 21:27
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #8494 (0db46df) into master (06f8637) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8494      +/-   ##
==========================================
- Coverage   40.80%   40.73%   -0.07%     
==========================================
  Files         686      686              
  Lines       75501    75501              
==========================================
- Hits        30808    30757      -51     
- Misses      39378    39424      +46     
- Partials     5315     5320       +5     
Impacted Files Coverage Δ
itests/kit/blockminer.go 70.65% <0.00%> (-17.94%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <0.00%> (-3.61%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-2.44%) ⬇️
node/impl/full/mpool.go 46.95% <0.00%> (-1.74%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
... and 14 more

@magik6k magik6k merged commit 4bd0399 into master Apr 15, 2022
@magik6k magik6k deleted the gstuart/bump-xtools branch April 15, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants