fix: market: Infer index provider topic from network name by default #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
changed the title
masih
force-pushed
the
idxprov-topic-by-netname
branch
from
7fe4213
to
1f7569d
Compare
Codecov Report
@@ Coverage Diff @@
## master #8526 +/- ##
==========================================
- Coverage 40.86% 40.75% -0.11%
==========================================
Files 686 686
Lines 75582 75587 +5
==========================================
- Hits 30883 30804 -79
- Misses 39374 39451 +77
- Partials 5325 5332 +7
|
masih
force-pushed
the
idxprov-topic-by-netname
branch
3 times, most recently
from
34eb836
to
fbb57e8
Compare
Index provider integration uses a gossipsub topic to announce changes to the advertised content. The topic name was fixed to the default topic which is `/indexer/ingest/mainnet`. In the case of lotus, the gossipsub validators enforce a list of topics the instance is permitted to join by setting subscription filter option when `PubSub` instance is constructed via DI. Having the fixed topic name meant that any SP starting up a node on a network other than `mainnet` would have to override the default config to avoid the node crashing when index provider is enabled. Instead of a fixed default, the changes here infer the allowed indexer topic name from network name automatically if the topic configuration is left empty. Fixes filecoin-project#8510
masih
force-pushed
the
idxprov-topic-by-netname
branch
from
fbb57e8
to
f273a44
Compare
|
@jennijuju there seems to be some flaky tests that I don't believe are failing because of the changes in this PR. I can't re-trigger the tests due to permissions. |
|
tested in devnet and works |
ZenGround0
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #8510
Proposed Changes
Instead of a fixed default, the changes here infer the allowed indexer
topic name from network name automatically if the topic configuration is
left empty.
Additional Info
Index provider integration uses a gossipsub topic to announce changes to
the advertised content. The topic name was fixed to the default topic
which is
/indexer/ingest/mainnet.In the case of lotus, the gossipsub validators enforce a list of topics
the instance is permitted to join by setting subscription filter option
when
PubSubinstance is constructed via DI.Having the fixed topic name meant that any SP starting up a node on a
network other than
mainnetwould have to override the default configto avoid the node crashing when index provider is enabled.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps