Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cli: Alias cli commands for uniformity #8587

Merged
merged 2 commits into from
May 4, 2022

Conversation

geoff-vball
Copy link
Contributor

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #8587 (0869bea) into master (33f190c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8587      +/-   ##
==========================================
- Coverage   40.78%   40.78%   -0.01%     
==========================================
  Files         686      686              
  Lines       75710    75710              
==========================================
- Hits        30882    30877       -5     
+ Misses      39495    39488       -7     
- Partials     5333     5345      +12     
Impacted Files Coverage Δ
cli/chain.go 39.94% <ø> (ø)
cli/net.go 7.63% <ø> (ø)
cli/state.go 1.06% <ø> (ø)
cmd/lotus-miner/actor.go 7.92% <ø> (ø)
cmd/lotus-miner/proving.go 25.92% <ø> (ø)
cmd/lotus-shed/blockmsgid.go 0.00% <ø> (ø)
cmd/lotus-shed/keyinfo.go 0.00% <ø> (ø)
cmd/lotus-shed/miner.go 0.00% <ø> (ø)
cmd/lotus-shed/mpool.go 0.00% <ø> (ø)
cmd/lotus-shed/msg.go 0.00% <ø> (ø)
... and 21 more

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't feel the need to add aliases unless needed because the name is changing, but don't see any harm in doing so.

@geoff-vball geoff-vball merged commit 27e99ff into master May 4, 2022
@geoff-vball geoff-vball deleted the gstuart/cli-uniformity branch May 4, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants