Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: Fix flaky TestGatewayWalletMsig #8601

Merged
merged 1 commit into from
May 4, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented May 4, 2022

Test was creating msig wallet with a vesting schedule. Test was checking if total funds were strictly less than the total amount to be vested, which created a race condition. We now check if funds are equal or less than total vesting funds.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner May 4, 2022 19:49
@magik6k magik6k merged commit d8f1380 into master May 4, 2022
@magik6k magik6k deleted the gstuart/flaky-gateway-test branch May 4, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants