Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: state: Set exec trace subcalls to nil when appropriate #8804

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jun 3, 2022

Proposed Changes

Change exec trace subcalls to be nil instead of empty array to preserve backwards compatibility.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner June 3, 2022 19:16
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change PR title to something shorter ("Fix: state: Set exec trace subcalls to nil when appropriate"), and include the motivation (backwards compatibility) in the PR description.

chain/vm/fvm.go Outdated Show resolved Hide resolved
@geoff-vball geoff-vball force-pushed the gstuart/exec-trace-consistency branch from 575fc42 to 0c789b0 Compare June 3, 2022 19:21
@geoff-vball geoff-vball changed the title Fix: state: Call with no subcalls is nil instead of empty array for backwards compatibility Fix: state: Set exec trace subcalls to nil when appropriate Jun 7, 2022
@arajasek arajasek disabled auto-merge June 7, 2022 13:39
@arajasek arajasek merged commit 0e5e5f4 into release/v1.16.0 Jun 7, 2022
@arajasek arajasek deleted the gstuart/exec-trace-consistency branch June 7, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants