-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API: support typed errors over RPC #9061
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
93f94d4
feat: support typed errors over RPC
arajasek 6189932
chore: deps: update to go-jsonrpc 0.1.8
arajasek 5b96496
remove duplicate import
arajasek 0626286
fix: itest: check for closed connection
arajasek 3c195e4
chore: refactor: move retry test to API
arajasek 3e81c56
address magik supernit
arajasek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,19 +7,21 @@ import ( | |
"golang.org/x/xerrors" | ||
|
||
"github.com/filecoin-project/go-jsonrpc" | ||
|
||
"github.com/filecoin-project/lotus/api" | ||
) | ||
|
||
func TestRetryErrorIsInTrue(t *testing.T) { | ||
errorsToRetry := []error{&jsonrpc.RPCConnectionError{}} | ||
require.True(t, ErrorIsIn(&jsonrpc.RPCConnectionError{}, errorsToRetry)) | ||
require.True(t, api.ErrorIsIn(&jsonrpc.RPCConnectionError{}, errorsToRetry)) | ||
} | ||
|
||
func TestRetryErrorIsInFalse(t *testing.T) { | ||
errorsToRetry := []error{&jsonrpc.RPCConnectionError{}} | ||
require.False(t, ErrorIsIn(xerrors.Errorf("random error"), errorsToRetry)) | ||
require.False(t, api.ErrorIsIn(xerrors.Errorf("random error"), errorsToRetry)) | ||
} | ||
|
||
func TestRetryWrappedErrorIsInTrue(t *testing.T) { | ||
errorsToRetry := []error{&jsonrpc.RPCConnectionError{}} | ||
require.True(t, ErrorIsIn(xerrors.Errorf("wrapped: %w", &jsonrpc.RPCConnectionError{}), errorsToRetry)) | ||
require.True(t, api.ErrorIsIn(xerrors.Errorf("wrapped: %w", &jsonrpc.RPCConnectionError{}), errorsToRetry)) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically those tests should also be moved to |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supernit: