-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Modules to 2 types: ActiveModule and PassiveModule #98
Generalize Modules to 2 types: ActiveModule and PassiveModule #98
Conversation
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
I think I addressed all the comments with what I've just pushed. Pls have a look and resolve the conversations if you are happy with the changes. Thanks! |
And what about |
8ab2819
to
d001a6a
Compare
Oh yes, I forgot about that. Fixed now. |
// Start one concurrent worker for each event in the input list. | ||
// Note that the processing starts concurrently for all events, and only the writing of the results is synchronized. | ||
iter := eventsIn.Iterator() | ||
i := 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The i
variable? It is, as each goroutine needs to know the index of its output channels and the Iterator
implementation does not provide that information.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a massive PR! Good job 👍
d001a6a
to
a5f7fd0
Compare
Ok I think I addressed all the stuff from above that required changes, plus I fixed the problem with the debugger not working. |
7babfef
to
64c0c50
Compare
Signed-off-by: Matej Pavlovic <[email protected]>
9e6bde8
to
0cb26c7
Compare
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Use an explicit definition of the ImplementsModule function in each Module implementation instead of including the Module interface as an anonymous field. This smells less like abusing OO concepts in a non-OO language. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
The foreign module names in ISS, currently defined as package-level variables, are only a temporary measure until these values become part of the ISS protocol configuration data structure. Until then, they stay "hard-coded" this way. Also, the OwnModuleName is renamed to issModuleName (instead of ownModuleName) Signed-off-by: Matej Pavlovic <[email protected]>
More concretely, in node.go and pkg/deploytest/deployment.go Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Remove the "key-value store"-like methods for public key management. If the crypto implementation needs to store public key information, it should manage the public keys out-of-band. Signed-off-by: Matej Pavlovic <[email protected]>
0cb26c7
to
c2f001f
Compare
This is a very big PR, but each commit should be rather easily digestible.