Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fvm-wasm-instrument stack limiter and gas #494
feat: fvm-wasm-instrument stack limiter and gas #494
Changes from all commits
096ae9d
f5b4f7f
d093b53
48d78e0
a85bc94
e3868bf
79b7a3a
0183944
689f8a1
ef868f2
d926f97
7fe3153
e4282ee
9d2e98c
fc651b3
d1a7ecd
8880415
95f4de3
ced762b
4f4cd7e
75376c6
5841c2a
06dda99
d776857
72ce6df
b7f6b88
43127db
c2b5e38
0adb846
0c69efc
ea08252
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stebalien do we not have sugar for creating Fatal errors with string interpolations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyhow!("foo").or_fatal()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird, it feels like we're doing borrow checking at runtime. Can't we write this code in a way that the Rust borrow checker guarantees the correctness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, no. But we could probably avoid this dance by remembering the starting gas in the
InvocationContext
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could, but I don't see a great way to do this, especially with the dance that happens in syscall handlers.