propagate all gas outputs in ApplyRet #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 4, 2022
raulk
approved these changes
May 4, 2022
Comment on lines
+76
to
+78
| pub base_fee_burn: TokenAmount, | ||
| pub over_estimation_burn: TokenAmount, | ||
| pub refund: TokenAmount, |
There was a problem hiding this comment.
Let's continue using BigInt here. TokenAmount is aliased to BigInt, so not a big deal, but I'd prefer to contain entropy.
There was a problem hiding this comment.
Hm. We should probably go the other way so we can eventually get rid of that alias, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #523.
Also fixes a bug in system actors state, which was broken and revealed by the cbor4ii library (which is stricter than its predecessor).