chore: use a specific Rust nightly version #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
force-pushed
the
pin-rust-nightly
branch
2 times, most recently
from
477a16b
to
8be8bda
Compare
Currently Rust nightly is needed as the currently used `bellperson` version needs else wouldn't build on ARM64. Using a specific version makes sure that we don't get arbitrary Clippy failures on CI. Also fix Clippy warning that comes up with using this nightly version.
|
Sorry for all the force pushing. This should now be on most recent master, with a better fix for the Clippy warning. |
raulk
reviewed
May 9, 2022
raulk
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Rust nightly is needed as the currently used
bellpersonversionneeds else wouldn't build on ARM64. Using a specific version makes sure
that we don't get arbitrary Clippy failures on CI.
Also fix Clippy warning that comes up with using this nightly version.