Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strongly typed gas units, and fix two related bugs #562

Merged
merged 2 commits into from
May 15, 2022
Merged

Strongly typed gas units, and fix two related bugs #562

merged 2 commits into from
May 15, 2022

Commits on May 15, 2022

  1. chore: fix price-list milligas/gas mixup

    @Stebalien
    Stebalien committed May 15, 2022
    Configuration menu
    Copy the full SHA
    53deec5 View commit details
    Browse the repository at this point in the history

  2. feat: strongly typed gas units 

    This adds a new gas type to avoid things like:

1. Multiplying gas by gas (not possible now).
2. Swapping gas/milligas.
3. Not using saturating arithmetic.

This change also caught and fixed a bug where the "extra" consensus
fault fee from lotus was being charged as milligas, not gas.

Motivation: the previous commit that fixed a bug in window post cost
scaling.
    @Stebalien
    Stebalien committed May 15, 2022
    Configuration menu
    Copy the full SHA
    5baa787 View commit details
    Browse the repository at this point in the history