Frrist/multisig transactions 154 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
commented
Nov 4, 2020
| return out, nil | ||
| } | ||
|
|
||
| changes, err := multisig.DiffPendingTransactions(ec.PrevState, ec.CurrState) |
There was a problem hiding this comment.
note: transactions that were removed could either have been canceled, executed and failed or executed and succeeded. Needing to spend a bit more time thinking if we can gather that info here, my gut says no..
willscott
approved these changes
Nov 4, 2020
| "method" bigint not null, | ||
| "params" bytea not null, | ||
| "approved" json not null, | ||
| PRIMARY KEY ("height", "multisig_id", "state_root", "transaction_id") |
There was a problem hiding this comment.
do you want state_root after multisig_id here?
frrist
force-pushed
the
frrist/multisig-transactions-154
branch
from
549abbd
to
dbcd454
Compare
frrist
force-pushed
the
frrist/multisig-transactions-154
branch
from
dbcd454
to
113f39b
Compare
frrist
force-pushed
the
frrist/multisig-transactions-154
branch
from
113f39b
to
22ca44a
Compare
frrist
added a commit
that referenced
this pull request
Nov 18, 2020
frrist
added a commit
that referenced
this pull request
Nov 18, 2020
placer14
added a commit
that referenced
this pull request
Nov 18, 2020
…ck-not-acquired * origin/master: feat: allow application name to be passed in postgres connection url (#243) chore: remove unused tables and views fix: multisig actor migration fix: lotus chain store is a blockstore feat: limit history indexer by height (#234) polish: Avoid duplicate work when reading receipts fix: missed while closing #201 fix: gracefully disconnect from postgres on exit polish: use new init actor diffing logic fix: don't update go modules when running make fix: panic in multisig genesis task casting feat: extract msig transaction hamt Create lint.yml (#164) remove null bytes from message params (#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #154
blocked on filecoin-project/lotus#4719