feat(task): add chain economics processing #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
force-pushed
the
iand/chain-economics
branch
from
a65cc2d
to
dc5e054
Compare
willscott
approved these changes
Oct 13, 2020
tasks/chain/economics.go
Outdated
| batchInterval = 100 * time.Millisecond // time to wait between batches | ||
| ) | ||
|
|
||
| var log = logging.Logger("message") |
There was a problem hiding this comment.
name the logger "ChainEconomics"?
There was a problem hiding this comment.
Renamed to "chain" to match the package name
Comment on lines
+94
to
+99
| if err := p.processItem(ctx, item); err != nil { | ||
| log.Errorw("failed to process tipset", "error", err.Error(), "height", item.Height) | ||
| if err := p.storage.MarkTipSetEconomicsComplete(ctx, item.TipSet, item.Height, p.clock.Now(), err.Error()); err != nil { | ||
| log.Errorw("failed to mark tipset economics complete", "error", err.Error(), "height", item.Height) | ||
| } | ||
| continue |
There was a problem hiding this comment.
if processing fails, we'll never actually error out of processing. is that intentional?
There was a problem hiding this comment.
Yes. A single failed tipset should not fail the entire batch or stop the processor from moving onto a new batch
iand
force-pushed
the
iand/chain-economics
branch
from
2582185
to
45dd5d0
Compare
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
* origin/master: feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101)
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
…-view * origin/master: feat: Add miner_sector_posts tracking of window posts (#74) feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101) fix: remove errgrp from UnindexedBlockData persist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.