This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Baseline migration #1215
Merged
Baseline migration #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
======================================
Coverage 71.0% 71.1%
======================================
Files 65 69 +4
Lines 6772 6800 +28
======================================
+ Hits 4814 4837 +23
- Misses 1183 1186 +3
- Partials 775 777 +2 |
|
@anorth these things are decoupled from the raw math and worth your review (especially the first bullet)
It will help to read this commit by commit |
anorth
approved these changes
Oct 6, 2020
21 tasks
davidad
suggested changes
Oct 6, 2020
- Migrate reward actor state - Cleanup: math.Precision -> math.Precision128 - Cleanup: move ln from smoothing to math - Cleanup: move expneg from reward to math - Hook up reward actor with migrated power state - Move SimpleTotal, BaselineTotal on chain - Compute new baseline total in migration
ZenGround0
force-pushed
the
feat/baseline-migration
branch
from
b52ae20
to
4d53729
Compare
davidad
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
All issues have been fixed, looks great to me now. Thank you @ZenGround0!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is motivated by the cryptoecon effort to fix some outstanding reward logic issues introduced in the 94000 upgrade.